Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor DAC script update. #15148

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Minor DAC script update. #15148

merged 1 commit into from
Feb 15, 2022

Conversation

andy31415
Copy link
Contributor

Problem

dacs.py not directly executable.

Change overview

make the script executable, add #!/usr/bin/env python to the top, make it throw if it cannot find the chip-tool binary (very likely if not knowing how/if to build it).

Testing

Ran the tool without error. Could not validate since the output does seem different from what is already in our source code.

@andy31415 andy31415 requested a review from cecille February 14, 2022 15:19
@github-actions
Copy link

github-actions bot commented Feb 14, 2022 •
edited
Loading

PR #15148: Size comparison from e439cb0 to 9162386

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e439cb0 9162386 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 592782 592782 0 0.0
.app_xip_area 498260 498260 0 0.0
.bss 77220 77220 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 550850 550850 0 0.0
.app_xip_area 457896 457896 0 0.0
.bss 75692 75692 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569362 569362 0 0.0
.app_xip_area 467152 467152 0 0.0
.bss 84620 84620 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909216 909216 0 0.0
(read/write) 127384 127384 0 0.0
.bss 125352 125352 0 0.0
.data 2032 2032 0 0.0
.text 909208 909208 0 0.0
BRD4161A+rpc (read only) 937912 937912 0 0.0
(read/write) 144304 144304 0 0.0
.bss 142128 142128 0 0.0
.data 2172 2172 0 0.0
.text 937904 937904 0 0.0
window-app BRD4161A (read only) 844388 844388 0 0.0
(read/write) 125444 125444 0 0.0
.bss 123544 123544 0 0.0
.data 1900 1900 0 0.0
.text 844380 844380 0 0.0
esp32 all-clusters-app c3devkit (read only) 944966 944966 0 0.0
(read/write) 1398610 1398610 0 0.0
.dram0.bss 66408 66408 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199032 199032 0 0.0
.flash.text 944966 944966 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 994959 994959 0 0.0
(read/write) 463896 463896 0 0.0
.dram0.bss 71552 71552 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226152 226152 0 0.0
.flash.text 989575 989575 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683252 683252 0 0.0
.bss 76656 76656 0 0.0
.data 1904 1904 0 0.0
.text 598892 598892 0 0.0
lock k32w061+release (read/write) 688804 688804 0 0.0
.bss 77048 77048 0 0.0
.data 1948 1948 0 0.0
.text 604008 604008 0 0.0
linux all-clusters-app debug (read only) 2357313 2357313 0 0.0
(read/write) 140000 140000 0 0.0
.bss 54528 54528 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205797 205797 0 0.0
.text 1989170 1989170 0 0.0
bridge-app debug+rpc (read only) 1726317 1726317 0 0.0
(read/write) 84200 84200 0 0.0
.bss 38928 38928 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141676 141676 0 0.0
.text 1468021 1468021 0 0.0
chip-tool debug (read only) 8442845 8442845 0 0.0
(read/write) 245760 245760 0 0.0
.bss 32200 32200 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206352 206352 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 460085 460085 0 0.0
.text 7467173 7467173 0 0.0
chip-tool-ipv6only arm64 (read only) 8245380 8245380 0 0.0
(read/write) 353377 353377 0 0.0
.bss 50497 50497 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 248800 248800 0 0.0
.dynamic 560 560 0 0.0
.got 49064 49064 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 436108 436108 0 0.0
.text 7048004 7048004 0 0.0
door-lock-app debug (read only) 1931473 1931473 0 0.0
(read/write) 110488 110488 0 0.0
.bss 42000 42000 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173074 173074 0 0.0
.text 1609810 1609810 0 0.0
lighting-app debug+rpc (read only) 2055121 2055121 0 0.0
(read/write) 115736 115736 0 0.0
.bss 43008 43008 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165393 165393 0 0.0
.text 1734914 1734914 0 0.0
ota-provider-app debug (read only) 1864289 1864289 0 0.0
(read/write) 106200 106200 0 0.0
.bss 41856 41856 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157643 157643 0 0.0
.text 1555986 1555986 0 0.0
ota-requestor-app debug (read only) 1859697 1859697 0 0.0
(read/write) 107288 107288 0 0.0
.bss 42144 42144 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58536 58536 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151196 151196 0 0.0
.text 1559586 1559586 0 0.0
shell debug (read only) 2341673 2341673 0 0.0
(read/write) 141488 141488 0 0.0
.bss 61792 61792 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73192 73192 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206674 206674 0 0.0
.text 1978146 1978146 0 0.0
thermostat-no-ble arm64 (read only) 2151132 2151132 0 0.0
(read/write) 140689 140689 0 0.0
.bss 57521 57521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132908 132908 0 0.0
.text 1799968 1799968 0 0.0
tv-app debug (read only) 2529257 2529257 0 0.0
(read/write) 139392 139392 0 0.0
.bss 57152 57152 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197669 197669 0 0.0
.text 2158546 2158546 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398112 2398112 0 0.0
.bss 188476 188476 0 0.0
.data 5320 5320 0 0.0
.text 1360712 1360712 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360344 2360344 0 0.0
.bss 181088 181088 0 0.0
.data 5624 5624 0 0.0
.text 1322944 1322944 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323872 2323872 0 0.0
.bss 180976 180976 0 0.0
.data 5600 5600 0 0.0
.text 1286472 1286472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308900 2308900 0 0.0
.bss 178228 178228 0 0.0
.data 5424 5424 0 0.0
.text 1271472 1271472 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1016131 1016131 0 0.0
bss 121412 121412 0 0.0
rodata 120096 120096 0 0.0
text 695660 695660 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 985407 985407 0 0.0
bss 118600 118600 0 0.0
rodata 111620 111620 0 0.0
text 675548 675548 0 0.0
nrf52840dongle_nrf52840 (read/write) 1031991 1031991 0 0.0
bss 122800 122800 0 0.0
rodata 118976 118976 0 0.0
text 700280 700280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 922774 922774 0 0.0
bss 117976 117976 0 0.0
rodata 113336 113336 0 0.0
text 610684 610684 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 945859 945859 0 0.0
bss 119784 119784 0 0.0
rodata 108856 108856 0 0.0
text 638692 638692 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853386 853386 0 0.0
bss 116376 116376 0 0.0
rodata 102028 102028 0 0.0
text 554492 554492 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 944679 944679 0 0.0
bss 119504 119504 0 0.0
rodata 107812 107812 0 0.0
text 638748 638748 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 940623 940623 0 0.0
bss 119508 119508 0 0.0
rodata 107508 107508 0 0.0
text 634988 634988 0 0.0
shell nrf52840dk_nrf52840 (read/write) 807179 807179 0 0.0
bss 111216 111216 0 0.0
rodata 79104 79104 0 0.0
text 539280 539280 0 0.0
p6 all-clusters-app default (read/write) 2483136 2483136 0 0.0
.bss 117744 117744 0 0.0
.data 2672 2672 0 0.0
.text 1441400 1441400 0 0.0
light-app default (read/write) 2389952 2389952 0 0.0
.bss 107392 107392 0 0.0
.data 2520 2520 0 0.0
.text 1348216 1348216 0 0.0
lock-app default (read/write) 2353416 2353416 0 0.0
.bss 107112 107112 0 0.0
.data 2480 2480 0 0.0
.text 1311680 1311680 0 0.0
qpg lighting-app qpg6105+debug (read only) 595044 595044 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88936 88936 0 0.0
.data 1108 1108 0 0.0
.text 589724 589724 0 0.0
lock-app qpg6105+debug (read only) 560772 560772 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1060 1060 0 0.0
.text 555452 555452 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 875102 875102 0 0.0
bss 88736 88736 0 0.0
noinit 37160 37160 0 0.0
text 614832 614832 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit f05070a into project-chip:master Feb 15, 2022
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@andy31415 @fuxingguo16
Make DACS script executable and add error if expected tool file not f…
fea9730 
…ound (project-chip#15148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@emargolis emargolis emargolis approved these changes

@cecille cecille cecille approved these changes

@LuDuda LuDuda LuDuda approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andy31415 @tcarmelveilleux @LuDuda @cecille @emargolis @bzbarsky-apple